Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation of Xiaomi Smart WiFi Socket and Power Strip component #3248

Merged
merged 6 commits into from
Oct 9, 2017
Merged

Documentation of Xiaomi Smart WiFi Socket and Power Strip component #3248

merged 6 commits into from
Oct 9, 2017

Conversation

syssi
Copy link
Member

@syssi syssi commented Aug 26, 2017

Pull request in home-assistant: home-assistant/core#9138

+New-component/platform

@fabaff fabaff added the new-integration This PR adds documentation for a new Home Assistant integration label Aug 26, 2017

Current supported features are `on`, `off`. If the device provides the current load it will be reported.

## {% linkable_title Getting started %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved the instructions from the vacuum platform to the component.

https://home-assistant.io/components/xiaomi/#retrieving-the-access-token

We don't want to maintain the same stuff at multiple locations.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack.

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Found some minor spelling & grammar issues.


The `xiaomi_plug` switch platform allows you to control the state of your Xiaomi Smart WiFi Socket aka Plug or Xiaomi Smart Power Strip.

Current supported features are `on`, `off`. If the device provides the current load it will be reported.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*Spelling & Grammar:

  • Current supported features are -> Currently, the supported features are
  • Missing comma after load-> the current load, it will be reported.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :-)

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@syssi Thx for fixing the spelling & grammar issues 🥇

@balloob balloob merged commit 4574c08 into home-assistant:next Oct 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-integration This PR adds documentation for a new Home Assistant integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants