added documentation for monoprice platform #3495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
fabaff
requested changes
Oct 2, 2017
| footer: true | ||
| logo: mp-logo.svg | ||
| ha_category: Media Player | ||
| ha_release: 0.25 |
There was a problem hiding this comment.
Which release version should I put there? 0.55?
| comments: false | ||
| sharing: true | ||
| footer: true | ||
| logo: mp-logo.svg |
There was a problem hiding this comment.
Please change the filename to monoprice.svg. Easier to identify if the name is there.
fabaff
added
Hacktoberfest
updated ha_release to 0.55
|
@fabaff I noticed that Monoprice logo is pure white and it is barely visible on white background. I'm not sure what you usually do in such cases but I'd suggest changing it to solid black or maybe black outline . |
|
How about something like |
|
@arsaboo I'm not sure about red because it is not one of Monoprice's colors. But I think black will work great. |
frenck
approved these changes
Oct 17, 2017
|
@fabaff, could you please revisit your approval? Thx 👍 |
fabaff
approved these changes
Oct 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This is a markdown for monoprice platform that enables control of Monoprice 6-zone amplifier
Pull request in home-assistant (if applicable): home-assistant/core#9662