Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some stale info from Z-Wave #3551

Merged
merged 1 commit into from
Oct 20, 2017
Merged

Remove some stale info from Z-Wave #3551

merged 1 commit into from
Oct 20, 2017

Conversation

emlove
Copy link
Contributor

@emlove emlove commented Oct 7, 2017

Description:
This PR removes some info about old version from the Z-Wave docs. It's been long enough now to remove it.

@@ -18,8 +18,6 @@ Before configuring the Z-Wave setup, please take a moment and read [this article

### {% linkable_title Installation %}

As of version 0.45, Home Assistant automatically installs python-openzwave from PyPI as needed.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After removing the version reference, I was originally going to move this below the installation steps shown. As it's written right now, the section starts off sounding like home assistant will automatically install what it needs, but then we give further instructions below. (Bad for skimming)

However, I'm thinking the line is unnecessary entirely. Home Assistant always auto-installs requirements. It's not really necessary to bring up here. We still have info about first run install time below anyway.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed.

@fabaff fabaff added Enhancement Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! labels Oct 8, 2017
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@frenck
Copy link
Member

frenck commented Oct 20, 2017

Thanks, @armills, that indeed is an improvement.

@frenck frenck merged commit c8729d1 into current Oct 20, 2017
@frenck frenck deleted the armills-patch-1 branch October 20, 2017 07:14
fabaff pushed a commit that referenced this pull request Oct 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants