Documentation for modbus timeout PR #3570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
fabaff
requested changes
Oct 9, 2017
source/_components/modbus.markdown
Outdated
| ``` | ||
|
|
||
| Configuration variables: | ||
|
|
||
| - **type** (*Required*): Type of the connection to Modbus. | ||
| - **host** (*Required*): The IP address of your Modbus device, eg. 192.168.1.1. | ||
| - **port** (*Required*): The port for the communication. | ||
| - **timeout** (*Optional*): Timeout for slave response in seconds. |
There was a problem hiding this comment.
And please add the default value.
source/_components/modbus.markdown
Outdated
| @@ -46,6 +48,7 @@ modbus: | |||
| stopbits: 1 | |||
| bytesize: 8 | |||
| parity: N | |||
| timeout: 1 | |||
source/_components/modbus.markdown
Outdated
| @@ -26,13 +26,15 @@ modbus: | |||
| type: tcp | |||
| host: IP_ADDRESS | |||
| port: 2020 | |||
| timeout: 0.5 | |||
There was a problem hiding this comment.
We try to keep all configuration samples minimal. Thus, no optional requirement in the default sample. This helps user to get started quickly by copy-&-paste the sample without worrying about optional parameters which they most likely not need. If required, insert a full configuration sample later that covers special setups or alike.
fabaff
added
Hacktoberfest
fabaff
approved these changes
Oct 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Pull request in home-assistant (if applicable): home-assistant/core#9780