Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MQTT broker docs for clarity #3573

Merged
merged 2 commits into from
Oct 11, 2017
Merged

Conversation

DubhAd
Copy link
Contributor

@DubhAd DubhAd commented Oct 9, 2017

Adding words to note that the reason a "run your own" broker is the most private is because the embedded broker doesn't support TLS/SSL.
Also updating to use the new configuration tags.

Adding words to note that the reason a "run your own" broker is the most private is because the embedded broker doesn't support TLS/SSL.
Also updating to use the new configuration tags.
@fabaff
Copy link
Member

fabaff commented Oct 9, 2017

hbmqtt supports SSL/TLS. Thus, the embedded broker support it but requires configuration.

@fabaff fabaff added Enhancement Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! labels Oct 9, 2017
@DubhAd
Copy link
Contributor Author

DubhAd commented Oct 10, 2017

Ah, their documentation makes no reference to it, but now you've mentioned it I had a poke at the source and see it. Will update.

Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🐦

@fabaff fabaff merged commit 263db7b into home-assistant:current Oct 11, 2017
@fabaff
Copy link
Member

fabaff commented Oct 11, 2017

It does...Features and configuration.

@DubhAd
Copy link
Contributor Author

DubhAd commented Oct 11, 2017

Darn it. Clearly my ability to RTFM is failing :/

@Danielhiversen
Copy link
Member

fabaff added a commit that referenced this pull request Oct 11, 2017
@fabaff
Copy link
Member

fabaff commented Oct 11, 2017

@Danielhiversen I know...should be fixed soon.

fabaff pushed a commit that referenced this pull request Oct 21, 2017
* Update MQTT broker docs for clarity

Adding words to note that the reason a "run your own" broker is the most private is because the embedded broker doesn't support TLS/SSL.
Also updating to use the new configuration tags.

* Update to reference hbmqtt supporting TLS
fabaff added a commit that referenced this pull request Oct 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants