-
-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collection of potential new Installers/Checkers/Dumpers #1337
Comments
Sounds like, based on the above:
Closing but happy to keep discussing here. |
Could you give a syntax example for the Brewfile explaining how you would envision this? I am likely misunderstanding this at the moment. |
I'm not sure yet. Are there extensions that only work on VSCode? VSCodium? VSCode Insiders? How can you find out? |
I am not sure about that but I am wondering whether that is actually … relevant? I would have thought it is the users' responsibility to put in valid data and the underlying application, e.g. vscodium, would validate this. Homebrew bundle only automates the invocation after all? |
@Okeanos I guess what I'm trying to understand is: what does supporting VSCodium/VSCode Insiders even look like? What breaks when using them today? |
Ah, I see. For VSCodium I just had a quick look at the docs:
For insiders / beta releases:
|
Falling back to |
Having thought about that a little:
To keep things simple I would have proposed to go through all known CLI names and attempt to install the extensions for all that were found (with proper log statements). However, for
Manual intervention at some level is required for that case. As a result I would propose to make Beyond that I would, as a first step ignore the insiders version for now instead ensuring that stable works (at all). |
This introduces too much complexity.
Why is this needed?
If manual intervention is required: it's not a good fit for homebrew-bundle.
This doesn't make sense to me. Settings like this are unintuitive and undiscoverable. |
Let me rephrase:
Codium makes no promises that all VSCode extensions are available to its users (for various reasons they outline in their docs). Obviously, brew wouldn't care and simply attempt to process user input and tell the user about the problem it (codium) encountered – same with any other option/parameter that an application implemented in brew-bundle cannot process. I would expect this to be a seldomly encountered error case (but have no hands on experience). I would specifically like to make it clear to the homebrew-bundle users what is happing for a number of reasons:
A "setting" (as in |
If this isn't something you use/need: I don't think you are the best person to design or implement this, sorry. |
That's fair. I wanted to give my input as an interested third party, however, to understand what could happen (in brew bundle, as a user), explore options for things I may be needing and want to contribute, and ultimately understand what you as maintainer think is feasible/sensible. Thanks a lot for your feedback and willingness to engage with me on this level ❤️ . |
Based on the recent discussions in #1329 (with the update to the repo via #1333) and comments in #1208 I want to collect a few thoughts on additional installers/checkers/dumpers I considered / had a very brief look at:
tlmgr
) packages #1329 unsuitable because the default installation requiressudo
; the user experience for not usingsudo
is not self-explanatory and difficult to explain in the context of homebrew-bundlejetbrains "tanvd.grazi", ide: "idea"
(maybe make the IDE option an array?) and force the users to provide the expected IDE name with little to no enforcement on bundle side (loose coupling).vscode
extensions #1208 and should probably work similar to VSCodevscode
extensions #1208) would probably require refactoring the vscode integration … maybe via avscode "GitHub.codespaces", insiders: true
-like syntax?The text was updated successfully, but these errors were encountered: