Removing deprecated service and characteristic definitions #989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 3562421843
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
♻️ Current situation
The current implementation exposes service and characteristic definitions which are marked deprecated for a long time now.
💡 Proposed solution
This PR removes the deprecated service and characteristic definitions.
The services serve no function anymore because their functionality got removed or was never implemented on the HomeKit client side.
⚙️ Release Notes
BridgeConfiguration,BridgingState,CloudRelay(orRelay),TimeInformationandTunnel. If you rely on the services (which you probably won't, as there technical functionality got removed on the HomeKit client side) you may copy those definitions from an older release ofhap-nodejs.➕ Additional Information
Testing
Removed the corresponding test cases.
Reviewer Nudging
--