inspect_app() is not the only possible source of a bundle identifier

[homebysix]

At the moment, Recipe Robot doesn't build a pkg recipe if there's no bundle_id in facts. However, I don't think we've considered that there are other possible ways to determine the bundle identifier even if we weren't able to collect it during inspect_app().

• Many Sparkle feeds provide bundle identifiers that SparkleUpdateInfoProvider grabs.
• AppDmgVersioner can be used to determine a bundle identifier. As long as we include that before the PkgCreator processor, we should be good to go.

[sheagcraig]

So let me get this straight-
inspect_app is happy if it has the app already on the system, where it's going to definitely need a bundle ID, and thus, inspect_app can 100% of the time get the ID.

I hear you about SparkleUpdateInfoProvider, although I would think that the ID in the actual app should be considered canonical, even over anything provided as Input variables or overrides.

I think it's very safe to assume that an app, if downloaded, will have a bundle ID, so yes, you can build a package recipe, knowing that it's going to need something to get the bundle ID (and version).

What that something is, is tricky. I think AppDmgVersioner right before PkgCreator is a good candidate, as it should be able to handle ANYTHING that is going to be immediately preceding PkgCreator. Right?

[homebysix]

Yes, if we've run inspect_app() then we should be pretty confident that we have the correct bundle id (and yes, that bundle id should override anything stored before it; I'll make that change).

If we haven't successfully inspected an app at some point along the line, it's likely that RR isn't going to be able to produce a full recipe set without manual intervention. But "likely" ≠ "guaranteed."

I'll try to find some edge case examples.