elementInViewport(): return false if element is falsey #1049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this PR is great -- i think the current code has been throwing errors in safari because no sanity check |
honestbleeps
added a commit
that referenced
this pull request
May 14, 2014
elementInViewport(): return false if element is falsey
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is somewhat related to PR #1048 -- you can dismiss this if you'd like as my other fix for the scrolling sidebar won't run into this issue any more.
None the less, I figured it wouldn't hurt to short circuit the RESUtils.elementInViewport function to return false if obj is falsey (e.g. doesn't exist)