Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filteReddit.keywords.unlessKeyword: don't filter a post if the title matches the unlessKeyword for that row #424

Merged

Conversation

jewel-andraia
Copy link
Collaborator

fixes #423

@honestbleeps
Copy link
Owner

i don't remember why we didn't merge this.

did you want to rebase and put this in?

@jewel-andraia
Copy link
Collaborator Author

i vaguely remember something about "is it really necessary?" but sure, I'll rebase this PR 😁

@kevinji
Copy link
Collaborator

kevinji commented Jan 21, 2014

@andytuba Recreate this PR as well?

@jewel-andraia
Copy link
Collaborator Author

Oh, thanks for the reminder, @mc10. I'll take care of that sometime this week.

@jewel-andraia
Copy link
Collaborator Author

rebased and ready to merge @honestbleeps

@jewel-andraia jewel-andraia added this to the v4.3.2.2 milestone Mar 30, 2014
honestbleeps added a commit that referenced this pull request Apr 14, 2014
filteReddit.keywords.unlessKeyword: don't filter a post if the title matches the unlessKeyword for that row
@honestbleeps honestbleeps merged commit 411d58b into honestbleeps:master Apr 14, 2014
@jewel-andraia jewel-andraia mentioned this pull request May 18, 2014
@jewel-andraia jewel-andraia deleted the filter-keyword-unless branch September 1, 2014 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "unless" textbox column to keywords filter
4 participants