Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Booleans in context are ignored #43

Closed
righi opened this issue Oct 3, 2013 · 2 comments
Closed

Booleans in context are ignored #43

righi opened this issue Oct 3, 2013 · 2 comments

Comments

@righi
Copy link

righi commented Oct 3, 2013

If I do the following in a before_filter...

Honeybadger.context({
  :debuga => true, 
  :debugb => 'true', 
  :debugc => false, 
  :debugd => 'false'})

...then Honeybadger logs this:

Context
{
  "debugb" => "true",
  "debugd" => "false"
}

The "string booleans" are preserved, but the real booleans are not. This is also true of deeply nested booleans in embedded hashes.

@joshuap
Copy link
Member

joshuap commented Oct 17, 2013

Hey thanks for the report. We're currently testing a beta release of 1.9.0 -- after we have a stable release, I'll get this fixed and bump to 1.9.1.

@joshuap
Copy link
Member

joshuap commented Nov 15, 2013

This has been fixed. It was actually just a UI issue on honeybadger.io -- the gem was sending the correct values. Thanks for the report!

@joshuap joshuap closed this as completed Nov 15, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants