feat: add additional context to ActiveJob notifications #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mikehale
commented
Mar 6, 2024
mikehale
commented
- Add additional context to error notification, and move parameters to context
- Simplify execution code
- Rename test file to reflect testing ActiveJob (no longer just async method)
stympy
requested changes
Mar 7, 2024
mikehale
force-pushed
the
activejob-context
branch
from
8e8d75c
to
c2de915
Compare
stympy
changed the title
|
It looks like there are some failing tests to address |
stympy
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.