Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typescript types #52

Merged
merged 1 commit into from
Apr 8, 2020
Merged

Add typescript types #52

merged 1 commit into from
Apr 8, 2020

Conversation

styfle
Copy link
Contributor

@styfle styfle commented Apr 24, 2019

Fixes #51

@lizthegrey
Copy link
Member

@toshok, would you mind taking a look? this is blocking me from creating an otel exporter.

src/honey.ts:23:27 - error TS7016: Could not find a declaration file for module 'libhoney'. '/home/lizf/hny/opentelemetry-exporter-js/node_modules/libhoney/dist/libhoney.cjs.js' implicitly has an 'any' type.
  Try `npm install @types/libhoney` if it exists or add a new declaration (.d.ts) file containing `declare module 'libhoney';`

23 import * as libhoney from 'libhoney';
                             ~~~~~~~~~~

@lizthegrey lizthegrey merged commit 7cb1bf5 into honeycombio:master Apr 8, 2020
@styfle styfle deleted the types branch April 8, 2020 20:17
@styfle
Copy link
Contributor Author

styfle commented Apr 8, 2020

FYI, these types were created a year ago for libhoney 1.2.1 so I have no idea if they are valid for 2.x 🤷‍♂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question: TypeScript Types?
3 participants