fix(secure-header): Replace NodeJS Buffer API #2761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you so much! |
yusukebe
reviewed
May 22, 2024
| @@ -1,5 +1,6 @@ | |||
| import type { Context } from '../../context' | |||
| import type { MiddlewareHandler } from '../../types' | |||
| import { bufferToBase64 } from '../../utils/buffer' | |||
There was a problem hiding this comment.
We can use encodeBase64!
import { encodeBase64 } from '../../utils/encode'
|
Hi @watany-dev ! Sorry! I intended to fix it, but thanks for your help. I've left a comment. |
|
Sorry for fixing it on my own, I chose the right API. |
|
Thanks! Merging now. |
nicolewhite
referenced
this pull request
in autoblocksai/cli
May 29, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [hono](https://hono.dev/) ([source](https://togithub.com/honojs/hono)) | [`4.3.8` -> `4.4.0`](https://renovatebot.com/diffs/npm/hono/4.3.8/4.4.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>honojs/hono (hono)</summary> ### [`v4.4.0`](https://togithub.com/honojs/hono/compare/v4.3.11...v4.4.0) [Compare Source](https://togithub.com/honojs/hono/compare/v4.3.11...v4.4.0) ### [`v4.3.11`](https://togithub.com/honojs/hono/releases/tag/v4.3.11) [Compare Source](https://togithub.com/honojs/hono/compare/v4.3.10...v4.3.11) #### What's Changed - fix(middleware/jwt): fix incorrect assumption in jwt impl by [@​boehs](https://togithub.com/boehs) in [https://github.com/honojs/hono/pull/2775](https://togithub.com/honojs/hono/pull/2775) #### New Contributors - [@​boehs](https://togithub.com/boehs) made their first contribution in [https://github.com/honojs/hono/pull/2775](https://togithub.com/honojs/hono/pull/2775) **Full Changelog**: honojs/hono@v4.3.10...v4.3.11 ### [`v4.3.10`](https://togithub.com/honojs/hono/releases/tag/v4.3.10) [Compare Source](https://togithub.com/honojs/hono/compare/v4.3.9...v4.3.10) #### What's Changed - fix(secure-header): Replace NodeJS Buffer API by [@​watany-dev](https://togithub.com/watany-dev) in [https://github.com/honojs/hono/pull/2761](https://togithub.com/honojs/hono/pull/2761) - fix(http-exception): prioritize the status code by [@​yusukebe](https://togithub.com/yusukebe) in [https://github.com/honojs/hono/pull/2767](https://togithub.com/honojs/hono/pull/2767) - feat(etag): export `RETAINED_304_HEADERS` by [@​yusukebe](https://togithub.com/yusukebe) in [https://github.com/honojs/hono/pull/2763](https://togithub.com/honojs/hono/pull/2763) **Full Changelog**: honojs/hono@v4.3.9...v4.3.10 ### [`v4.3.9`](https://togithub.com/honojs/hono/releases/tag/v4.3.9) [Compare Source](https://togithub.com/honojs/hono/compare/v4.3.8...v4.3.9) #### What's Changed - fix(factory): export `CreateHandlersInterface` by [@​yusukebe](https://togithub.com/yusukebe) in [https://github.com/honojs/hono/pull/2752](https://togithub.com/honojs/hono/pull/2752) - feat(aws-lambda): add support for alb multiValueQueryStringParameters by [@​yiss](https://togithub.com/yiss) in [https://github.com/honojs/hono/pull/2751](https://togithub.com/honojs/hono/pull/2751) **Full Changelog**: honojs/hono@v4.3.8...v4.3.9 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on Monday" in timezone America/Chicago, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/autoblocksai/cli). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNzcuOCIsInVwZGF0ZWRJblZlciI6IjM3LjM3Ny44IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close: #2725
The author should do the following, if applicable
bun denoifyto generate files for Denobun run format:fix && bun run lint:fixto format the code