feat: Tenant API & JWT authentication #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexluong
commented
Aug 28, 2024
Comment on lines
+1
to
+17
| package api_test | ||
|
|
||
| import ( | ||
| "net/http" | ||
| "net/http/httptest" | ||
| "testing" | ||
|
|
||
| "github.com/google/uuid" | ||
| "github.com/hookdeck/EventKit/internal/destination" | ||
| "github.com/hookdeck/EventKit/internal/services/api" | ||
| "github.com/hookdeck/EventKit/internal/tenant" | ||
| "github.com/hookdeck/EventKit/internal/util/testutil" | ||
| "github.com/stretchr/testify/assert" | ||
| ) | ||
|
|
||
| func TestRouterWithAPIKey(t *testing.T) { | ||
| t.Parallel() |
There was a problem hiding this comment.
Can you go over this test suite (this file)? I'm trying to test the router with a strong emphasis on the auth mechanism. Some questions:
- Can you follow the thought process / auth mechanism logic here? Is this the right approach? Any case I'm missing here?
- Do you feel this is too "auth-focused" and should be moved to
auth_middleware_test.goinstead? In that case, we can set up a smaller router vs this router with tenant & destination routes. Personally I'm fine with this and continue moving forward and we can consider that refactor after but curious if you share the sentiment.
alexluong
commented
Aug 28, 2024
| Port int | ||
| Hostname string | ||
| APIKey string | ||
| JWTSecret string |
There was a problem hiding this comment.
I assume we would need to add a JWT_SECRET env here, correct?
# Conflicts: # internal/config/config.go # internal/services/api/api.go # internal/services/api/auth_middleware.go # internal/services/api/router.go # internal/util/testutil/testutil.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fairly loaded PR. Here are everything it does:
Added tests for a lot of the new code here. Just a sidenote, I really do enjoy writing tests in Go and the workflow so far. Caught a bug in the auth middleware from writing a more semi-comprehensive test suite.