Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed xfce4 gtk3 panel plugin menus #800

Closed
wants to merge 1 commit into from

Conversation

zlamalp
Copy link
Contributor

@zlamalp zlamalp commented Jun 20, 2017

This should solve bold font issue #749 in xfce4 panel plugin menus for gtk3 widgets as proposed by @xiamaz.

@NicoHood
Copy link

NicoHood commented Nov 5, 2017

@xiamaz @zlamalp I tried to apply your fix and it now looks like this on my archlinux install:
screenshot from 2017-11-05 19-51-02

Now I got two questions:

  • The top bar bad normal and bold text mixed, shouldnt we make them normal for every applet?
  • About SASS: It seems you have to generate the css files from SASS, but they need to be tracked by git too. This means you need to run gulp, add the css files too and commit again?

I am new to building gtk themes, maybe someone can clarify this.

@zlamalp
Copy link
Contributor Author

zlamalp commented Nov 6, 2017

Hi @NicoHood, I guess you need to modify also something else, since XFCE is now mixing GTK2 and GTK3 for panel and its applets.
I personally use bold text on panel (manually added e.g. for clock clock), but it's a matter of taste. So if you want, fix it.
SASS....I wasn't even able to install gulp using npm (as described in HACKING.md). But I guess you should modify scss file and then compile it to css and commit it as a whole as you wrote.

@NicoHood
Copy link

NicoHood commented Jan 8, 2018

@zlamalp Can you please test your fix on the new release RC and open a new pr there?
arc-design/arc-theme#22

Edit: tested and fixed here: arc-design/arc-theme@4bd12f2

Please close this PR then.

NicoHood added a commit to arc-design/arc-theme that referenced this pull request Jan 8, 2018
@zlamalp zlamalp closed this Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants