Speedup by not running in isolation #32
Conversation
stefanlenselink
commented
Jun 7, 2016
stefanlenselink
commented
- Entity Generation not running in Isolation
- Updated PHPUnit to 5.4.2 -> fixed broken unit-test (never worked).
- Added hostnet/phpcs-tool and apply hostnet code style
- Added Unittest for Writer and the EmptyGenerator.
…ded hostnet/phpcs-tool to apply hostnet code style.
|
Hmm, the php 5.5 build fails due to the requirement on |
| @@ -223,7 +223,7 @@ private function generateConcreteIndividualCode(EntityPackageBuilder $graph) | |||
| $this->writeIfVeryVerbose( | |||
| ' - Generating interface for <info>' . $entity->getName() . '</info>' | |||
| ); | |||
| ReflectionGenerator::generateInIsolation($entity->getName()); | |||
| ReflectionGenerator::main($entity->getName()); | |||
There was a problem hiding this comment.
Since it's no longer process isolated, I'd expect the ReflectionGenerator to be created in the activate function of Plugin, which creates the whole dependency graph (and does no work). This should make the unit-tests a lot easier.
|
I agree, there's no need for people to keep using old php versions and makes maintenance easier. On a side note, it would be easier to review if you make different PRs out of this. I'm not entirely sure all changes are related to the same subject so it's hard to gain a proper overview of what's changed. |
| @@ -8,7 +8,7 @@ | |||
| * | |||
| * @author Nico Schoenmaker <nschoenmaker@hostnet.nl> | |||
| */ | |||
| interface PackagePathResolver | |||
| interface PackagePathResolverInterface | |||
There was a problem hiding this comment.
Please note that this is a BC break. If you're not planning on bumping a major, please add a BC layer for this
