Delete campaign

[Eleonore9]

• add functionality to delete campaign files on S3
• implement deletion in users (managers and watchers) json [waiting on campaign json update]
• implement deletion from the UI and redirect to user's page (My projects)
• notify the user that the deletion has worked

---

Changes after review:

• add text in the popup window "This operation cannot be undone"
• fix display attribute of popup so it doesn't break in Chrome
• use bootstrap Modal for the popup window
• when looking up managers/viewers take into account the new json structure

"campaign_viewers": [
  { osm_id: "123456", name: "Jo Sprague" },
  { osm_id: "987654", name: "Russ Biggs" }
]

• create a test campaign.json file to test

Closes issue #669

[russbiggs]

Looks like there is some styling issues on this:

[Eleonore9]

@russbiggs this looks more like you can't see half of it! I've added screenshot in the PR description.
I'm not sure of what's going on? How are you running it locally?

[localjo]

It looks like the screenshot @russbiggs posted was because of this line. Would setting display: block work?

[Eleonore9]

Thank you!! Yes, It'll work (with more styling)!

[localjo]

We can use the Bootstrap modal here, since the project already has the CSS and JS for it. Here's an example: https://getbootstrap.com/docs/3.4/javascript/#modals-examples

We're currently using this for other modals in the app, like the warning when someone tries to click "Create" before logging in, and the modal when a user adds types during campaign creation.

We'll have to write some CSS overrides to make the modal match the new design. I think those overrides could go in flask_project/campaign_manager/styles/components/_modal.scss.

[Eleonore9]

OK, thanks! I'll change to using a modal for the popup! 👌

[russbiggs]

This looks pretty much complete. We just need to hide the delete button in the jinja template in the header in the case where the user is not a manager of the campaign. Although not necessarily secure it would be good to do a check on the delete handler server side as well.

[Eleonore9]

This looks pretty much complete. We just need to hide the delete button in the jinja template in the header in the case where the user is not a manager of the campaign. Although not necessarily secure it would be good to do a check on the delete handler server side as well.

Sure! I hadn't realised it was to be done on my end.