Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix removal of project teams while updating them. #5917

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

Aadesh-Baral
Copy link
Contributor

closes #5916

This commit fixes an issue where the ProjectTeams object was not added to the session, causing projects teams being removed while updating them. By adding the ProjectTeams object to the session after its creation, the subsequent add operation on Project.teams can proceed without any issues.

The changes ensure that the ProjectTeams object is properly associated with the session, allowing for the correct handling of relationships within the update method.

…essful.

------------------------------------------------------------
This commit fixes an issue where the ProjectTeams object was not added to the session, causing projects teams being removed while updating them. By adding the project_team object to the session after its creation, the subsequent add operation on Project.teams can proceed without any issues.

The changes ensure that the ProjectTeams object is properly associated with the session, allowing for the correct handling of relationships within the update method.
@sonarcloud
Copy link

sonarcloud bot commented Jun 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@eternaltyro eternaltyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aadesh-Baral Aadesh-Baral merged commit b7aed52 into develop Jun 14, 2023
8 checks passed
@Aadesh-Baral Aadesh-Baral deleted the hotfix/5916-project-teams branch June 14, 2023 14:16
eternaltyro pushed a commit that referenced this pull request Jun 14, 2023
…essful. (#5917)

------------------------------------------------------------
This commit fixes an issue where the ProjectTeams object was not added to the session, causing projects teams being removed while updating them. By adding the project_team object to the session after its creation, the subsequent add operation on Project.teams can proceed without any issues.

The changes ensure that the ProjectTeams object is properly associated with the session, allowing for the correct handling of relationships within the update method.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Adding a team to the project removes all the existing project teams.
2 participants