Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update react dropzone #5966

Merged
merged 2 commits into from
Jul 10, 2023
Merged

Update react dropzone #5966

merged 2 commits into from
Jul 10, 2023

Conversation

tsmock
Copy link
Contributor

@tsmock tsmock commented Jul 6, 2023 •
edited by ramyaragupathy
Loading

No description provided.

@github-actions github-actions bot added scope: frontend dependencies Pull requests that update a dependency file javascript labels Jul 6, 2023
@tsmock tsmock force-pushed the chore/update-react-dropzone branch from bd51565 to dbc710b Compare July 6, 2023 21:18
HelNershingThapa
HelNershingThapa reviewed Jul 7, 2023
View reviewed changes
Copy link
Contributor

@HelNershingThapa HelNershingThapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When interacting with the markdown editor container, an unintended behavior occurs where clicking on it triggers the file selection dialog. This issue seems to be specific to Chrome and does not occur in Firefox
filezone

@tsmock
Copy link
Contributor Author

tsmock commented Jul 7, 2023

I forgot about that, especially since I test in Firefox, not chrome. I think I fixed that in the massive PR, I'll just have to find it.

@tsmock
Update react-dropzone to 14.2.3
8f87f11 
Signed-off-by: Taylor Smock <tsmock@meta.com>
@tsmock
React Dropzone: Avoid opening file dialogs in Chromium when clicking …
97d7b74 
…on `Write` or `Preview`

Signed-off-by: Taylor Smock <tsmock@meta.com>
@tsmock tsmock force-pushed the chore/update-react-dropzone branch from dbc710b to 97d7b74 Compare July 7, 2023 09:41
@sonarcloud
Copy link

sonarcloud bot commented Jul 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

@HelNershingThapa HelNershingThapa merged commit fc5f390 into hotosm:develop Jul 10, 2023
@tsmock tsmock deleted the chore/update-react-dropzone branch July 10, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HelNershingThapa HelNershingThapa HelNershingThapa approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file scope: frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tsmock @HelNershingThapa