Issue 698 #720
Merged
Issue 698 #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… instance variables instead of passing arguments around
…e interface isn't used elsewhere
….create_from_feed_data class method
…'else's This removes duplication with the success and failure cases and makes the logic easier to trace, imo.
…vent inconsistencies
… SubscriberToFeedDataConverter
… a local user that doesn't exist using the remote form)
…ting users when domain entered is the current one.
|
Pulling rank and merging!!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the remaining refactoring from Gavin's pull req that set up the fixes for the 2 cases of Issue #698.