Expose TurboSession allowing use outside the module #254
Conversation
| @@ -53,6 +54,7 @@ class TurboSession internal constructor( | |||
| internal val httpRepository = TurboHttpRepository(activity.lifecycleScope) | |||
| internal val requestInterceptor = TurboWebViewRequestInterceptor(this) | |||
| internal val fileChooserDelegate = TurboFileChooserDelegate(this) | |||
| var isRunningInAndroidNavigation = true | |||
There was a problem hiding this comment.
Public property with default true. Set in my library to false to change behavior callback method behavior.
| @@ -571,7 +573,7 @@ class TurboSession internal constructor( | |||
| private fun callback(action: (TurboSessionCallback) -> Unit) { | |||
| context.runOnUiThread { | |||
| currentVisit?.callback?.let { callback -> | |||
| if (callback.visitNavDestination().isActive) { | |||
| if (!isRunningInAndroidNavigation || callback.visitNavDestination().isActive) { | |||
There was a problem hiding this comment.
If statement mentioned in the PR description.
Fryzu
changed the title
|
@jayohms can you have a look here? |
|
Thank you for the PR, however this isn't a suitable change for the Android library. Proper internal/public separation is important to maintain the library long-term. The Android library is quite deliberate in providing fully native navigation and wasn't designed to use the While the iOS library may work for your needs, we have plans going forward for it to be more opinionated in providing out-of-the-box navigation and presentation between All the source code in |
Fixes: #245
Summary
Hello 👋 I am software engineer working for Software Mansion. Together with @pfeiffer we are working on React Native support for Turbo 🚀. Our goal is to add support for React Native hybrid apps on both iOS and Android for turbo enabled websites. Under the hood we use both Turbo Android and Turbo iOS. We have an almost ready version of our library, please check out our repo react-native-turbo-webview.
What's the problem?
iOS implementation with Turbo iOS was fairly easy, but the way Turbo Android depends on
Android Navigation, makes the Android-implementation less straightforward.
Turbo Android doesn't leave much freedom for our implementation and It is impossible to use it without the Android Navigation which we can't use in the case of React Native. We are forced to use session class directly, sadly it is not easy as it is marked with
internalvisibility modifiers.
We solved this problem in forked repo, at the moment we are using a patched version of
turbo-androidfor the PoC.
Removing
internalmodifiers makes it possible to use the package similarly to Turbo iOS and unifies the API. I do not see any reasons against the removal of modifiers but I am open to discussion over alternative solutions.Changes
TurboSessionclass accessible beyond module scope.isRunningInAndroidNavigationproperty (with defaulttrue) and changes one if statement condition. Does not change anything in the method whenisRunningInAndroidNavigationis false so it won't affect non React-Native users.