Add correct MIME type "image/jpeg" on image capture for file uploads #259
Conversation
Add correct MIME type "image/jpeg" for accept.
| @@ -56,7 +56,7 @@ internal class TurboCameraCaptureDelegate(val context: Context) { | |||
| private fun FileChooserParams.allowsCameraCapture(): Boolean { | |||
| val accept = defaultAcceptType() | |||
| val acceptsAny = accept == "*/*" | |||
| val acceptsImages = accept == "image/*" || accept == "image/jpg" | |||
| val acceptsImages = accept.contains("image/*") || accept.contains("image/jpg") || accept.contains("image/jpeg") | |||
There was a problem hiding this comment.
I'd prefer that we're a bit more strict here. We extract the default accept type, but we can also check the array of acceptTypes for the jpeg mime types.
This feels like a good balance to check that the default accept type is a wildcard type or the acceptTypes array supports jpegs. Here's what it'd look like:
val defaultAccept = defaultAcceptType()
val acceptsAny = defaultAccept == "*/*"
val acceptsImages = defaultAccept == "image/*" || acceptTypes.any {
it == "image/jpg" || it == "image/jpeg"
}| @@ -56,7 +56,7 @@ internal class TurboCameraCaptureDelegate(val context: Context) { | |||
| private fun FileChooserParams.allowsCameraCapture(): Boolean { | |||
| val accept = defaultAcceptType() | |||
| val acceptsAny = accept == "*/*" | |||
| val acceptsImages = accept == "image/*" || accept == "image/jpg" | |||
| val acceptsImages = accept.contains("image/*") || accept.contains("image/jpg") || accept.contains("image/jpeg") | |||
There was a problem hiding this comment.
The TurboCameraCaptureDelegateTest test class should be improved to handle cover these mime types:
image/*image/jpg(as the first and non-firstacceptType)image/jpeg(as the first and non-firstacceptType)
There was a problem hiding this comment.
Don't have a lot of experience in Kotlin and tests. I did try making some adding in new params and used assertThat(intent).isNotNull() but that made the buildIntent fail. Would need some help here.
|
Any chance of getting this branch merged? |
|
Closing in favor of #282 |
#141 is an awesome feature but was not working out of the gate. I was not using
"image/*"and saw that"image/jpg"was also set for accept but since I had"image/jpeg"it didn't work right away. There is no MIME type"image/jpg"and the actual type is"image/jpeg". This commit adds the correct MIME type while keeping"image/jpg"for anyone that used that with this feature. It'd probably be good to add more common image types in the future.Also changed to
.containsinstead of==so that if the string matches anywhere in accept it will be enabled. This will streamline using the feature as it is common to have multiple types such asaccept="image/jpeg, image/png, image/webp".