Page refreshes: Don't render previews #1098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunoprietog
force-pushed
the
morphing-do-not-render-previews
branch
from
2f8c066
to
0cfc08f
Compare
Fix Error when morphing a page when visiting it for the second time hotwired#1080
brunoprietog
force-pushed
the
morphing-do-not-render-previews
branch
from
0cfc08f
to
875d739
Compare
brunoprietog
changed the title
|
I think this would be really useful and the way to go - right now a previous version of the document is shown for a brief period of time while the before the refreshed page is being morphed leading to some potential weird flickering and defeats the niceness of the refresh with morphing. |
|
Makes sense, thanks @brunoprietog 🙏 We excluded page refreshes from the cache on async updates, but forgot to do the same in regular navigations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1080
In #1080, when rendering the cached snapshot as preview, idiomorph is causing
document.bodyto becomenull, I didn't quite understand why.Anyway, In my opinion morphing should not render previews anyway. If the goal of morphing is to maintain state, why would we want to do that and show a previous version of the document for a moment?
So, this PR does just that. If it is a page refresh, the cached snapshot will not be rendered as preview.