Don't lose focus due to autofocus when morphing pages #1267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgemanrubia
changed the title
|
I'll look into those tests... |
jorgemanrubia
force-pushed
the
morph-autofocus
branch
3 times, most recently
from
8cca8f8
to
2d69a4a
Compare
jorgemanrubia
force-pushed
the
morph-autofocus
branch
13 times, most recently
from
2f4a4d8
to
236d16f
Compare
Before this change, Turbo would always focus on the first element with `[autofocus]` when a page refresh with morphing happened (default behavior inherited from `PageRenderer`). With this change, it will never autofocus when a page refresh with morphing happens. This is meant to solve the problem where you are writing on a form, and it loses the focus because a broadcasted page refresh arrives.
jorgemanrubia
force-pushed
the
morph-autofocus
branch
from
236d16f
to
c818307
Compare
afcapel
approved these changes
May 30, 2024
|
Thanks for helping with those tests @afcapel 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, Turbo would always focus on the first element with
[autofocus]when a page refresh with morphing happened (default behavior inherited fromPageRenderer). With this change, it will never autofocus when a page refresh with morphing happens.This is meant to solve the problem where you are writing on a form, and it loses the focus because a broadcasted page refresh arrives.