Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to upgrade or lock rotp at v3.x #158

Closed
mindtonic opened this issue Nov 27, 2018 · 6 comments
Closed

Need to upgrade or lock rotp at v3.x #158

mindtonic opened this issue Nov 27, 2018 · 6 comments

Comments

@mindtonic
Copy link

rotp introduces breaking changes in version 4 [https://github.com/mdp/rotp#breaking-changes-in--40].

@andresantonioriveros
Copy link
Contributor

I found a problem with the otp verification. The verify_with_drift_and_prior call is broken, so I made a branch with a fix as an alternative to lock rotp:
https://github.com/resitcl/two_factor_authentication/commit/d462080c479825da2fcd27acf38c9dddd0a6ae78

I'm using rails 5.2, rotp 4.0.2. It seems to be the only problem that the upgrade introduces.

@kchasel
Copy link

kchasel commented Dec 5, 2018

Also ran into this issue. We downgraded to 3.3.1 to resolve but applying the above patch to upgradae this library to support rotp >= 4.0 would be great!

@macgill4444
Copy link

I also just ran into this issue and would also appreciate an upgrade! :)

@Migoo
Copy link

Migoo commented Jan 3, 2019

Same here. An update would be graciely appreciated

@andresantonioriveros
Copy link
Contributor

#159

@mindtonic
Copy link
Author

Wonderful! Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants