Skip to content

#27 #121 Replace json server.rewriter data with routes.json #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 2, 2022
Merged

#27 #121 Replace json server.rewriter data with routes.json #124

merged 4 commits into from
Oct 2, 2022

Conversation

metinbaris
Copy link
Contributor

Fixes #27 and #121

@metinbaris metinbaris requested a review from pfwd as a code owner September 28, 2022 02:01
@pfwd
Copy link
Contributor

pfwd commented Sep 29, 2022

@metinbaris Could you take a look at the conflicts. I've added eslint so you will need to run yarn install and then yarn run lint. Thanks

pfwd
pfwd requested changes Sep 29, 2022
View reviewed changes
Copy link
Contributor

@pfwd pfwd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check conflicts

@metinbaris
Copy link
Contributor Author

@pfwd 👍 seems better now :)

@metinbaris metinbaris requested a review from pfwd September 30, 2022 11:27
pfwd
pfwd reviewed Oct 1, 2022
View reviewed changes
@pfwd pfwd changed the title Replace json server.rewriter data with routes.json #27 #121 Replace json server.rewriter data with routes.json Oct 2, 2022
@pfwd pfwd merged commit 08d76a4 into howToCodeWell:main Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pfwd pfwd pfwd requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace jsonServer.rewriter data with routes.json
2 participants
@metinbaris @pfwd