Skip to content

Conversation

metinbaris
Copy link
Contributor

Fixes #120

@metinbaris metinbaris requested a review from pfwd as a code owner October 1, 2022 18:03
@metinbaris metinbaris marked this pull request as draft October 1, 2022 18:22
@metinbaris metinbaris force-pushed the Remove-the-port-from-the-API_BASE_PATH-in-the.env.sample-file branch from 76b824a to d515ead Compare October 1, 2022 18:32
@metinbaris
Copy link
Contributor Author

@pfwd Have one question, is it ok use it without url slash ?

There is "/" http://localhost/ at the end of url as described "#120 Acceptance Criteria"

To use the given port I had to change also test description for yarn test would please review it for me :)

@metinbaris metinbaris marked this pull request as ready for review October 1, 2022 18:39
@pfwd
Copy link
Contributor

pfwd commented Oct 1, 2022

@pfwd Have one question, is it ok use it without url slash ?

There is "/" http://localhost/ at the end of url as described "#120 Acceptance Criteria"

To use the given port I had to change also test description for yarn test would please review it for me :)

Good question. I haven't tried it without the slash.
Now you mention it, I actually prefer the API_BASE_PATH to not have the trailing slash so we can define that in the routes.
It should be ok as

return axiosClient.get('/quiz')
starts with the slash. This is covered by the following integration test

Could you try and remove it from the update the unit test? If the integration test fails then I may need to rethink how it works.

@metinbaris
Copy link
Contributor Author

@pfwd Just pushed the change, yes if we remove the slash at the end of the baseURL, requests should work fine

@pfwd pfwd merged commit 121186a into howToCodeWell:main Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the port from the API_BASE_PATH in the .env.sample file
2 participants