Create unit tests for app fixtures.php #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add protected method testing for getFilePaths
Php unit was blowing up if files were called by require_once, changed it to require
Add entityManager Change test name as KernelTestCase Update static assert calling for $this-> to self::
|
@pfwd needs your early review for some db tests, I left a comment related load function test would you mind having a look at it please :) |
metinbaris
commented
Oct 4, 2022
api/tests/unit/config/fixtures/data_fixtures/AppFixturesTest.php
Outdated
Show resolved
Hide resolved
Protected to Public
Methods are now publicly accessible for tests
Set object manager on load
Mock the ObjectManager, persist and flush method
pfwd
requested changes
Oct 8, 2022
api/tests/unit/config/fixtures/data_fixtures/AppFixturesTest.php
Outdated
Show resolved
Hide resolved
api/tests/unit/config/fixtures/data_fixtures/AppFixturesTest.php
Outdated
Show resolved
Hide resolved
api/tests/unit/config/fixtures/data_fixtures/AppFixturesTest.php
Outdated
Show resolved
Hide resolved
api/tests/unit/config/fixtures/data_fixtures/AppFixturesTest.php
Outdated
Show resolved
Hide resolved
api/tests/unit/config/fixtures/data_fixtures/AppFixturesTest.php
Outdated
Show resolved
Hide resolved
api/tests/unit/config/fixtures/data_fixtures/AppFixturesTest.php
Outdated
Show resolved
Hide resolved
Use ObjectManager::class instead of a string
metinbaris
force-pushed
the
Create-unit-tests-for-AppFixtures.php
branch
from
176e806 to
8411725
Compare
Thanks for reviews, I believe it improves my coding skills 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To test load function inside AppFixtures class
Should we run such command for creating test database and if yes where should we define it :) ?
docker-compose exec api bin/console --env=test doctrine:database:create