This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Updating typings for interactive messages #1318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updating SlackAttachment type for interactive messages - Updating Message type for interactive message handling
Naktibalda
suggested changes
Apr 23, 2018
lib/Botkit.d.ts
Outdated
| @@ -221,13 +221,18 @@ declare namespace botkit { | |||
| action?: string; | |||
| channel?: string; | |||
| match?: RegExpMatchArray; | |||
| replace_original?: boolean; | |||
| response_type?: string; | |||
There was a problem hiding this comment.
These properties are Slack specific, please move them to SlackMessage interface.
- Moving slack specific message properties to slackMessage interface
|
@Naktibalda I have moved the slack specific properties to the SlackMessage interface as suggested. Thanks for taking a look at this PR and providing feedback. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1317