[Slack] 👻 Add Ephemeral Message Support #958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonchurch
commented
Aug 15, 2017
| @@ -338,6 +337,10 @@ module.exports = function(botkit, config) { | |||
| }; | |||
|
|
|||
| bot.send = function(message, cb) { | |||
| if (message.ephemeral) { | |||
There was a problem hiding this comment.
I chose to retain a single send function, and just check if the message should be ephemeral or not
Using send like this also preserves access to these messages from send middlewares!
k001
reviewed
Aug 16, 2017
| attachments: message.attachments ? | ||
| JSON.stringify(message.attachments) : null, | ||
| }; | ||
| console.log({message}) |
There was a problem hiding this comment.
No good reason, ty for catching it
k001
reviewed
Aug 16, 2017
| JSON.stringify(message.attachments) : null, | ||
| }; | ||
| console.log({message}) | ||
| console.log({slack_message}) |
jonchurch
changed the title
benbrown
approved these changes
Aug 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First pass at this for everyone hungry to jump on the new features!
TLDR; We have bot.whisper now!!
This adds two new functions to Botkit to make use of the new
chat.postEphemeralWeb API method.bot.whisper():
Works just like bot.reply, takes a source message and clones the channel and user (user is required for this api method) and sends it. We also set
as_userto true to show the messages are coming from the bot user (or whoevers token you're making calls with). This can be overridden by settinguser: falseon the outgoing message body, or using the second new method:bot.sendEphemeral():
Works like bot.send, takes a botkit message with a channel and user (again, user is required for this method by slack) and sends a message, unprompted by the user.
Ephemeral in Conversations
Currently there is shakey support of interactive messages, slack is not sending the original message in the trigger payload, which is normally sent along with interactive message payloads.replyInteractive to ephemeral interactive messages doesnt update them either. I asked in the slack api channel but havent heard anything about this yet.That unfortunately makes ephemeral messages, at this time, not as feature rich as their standard counterparts, and doing complex user flows with updating their choices isnt possible currently in the ephemeral realm 👻Got a response from @episod! Interactive messages do work with ephem. However, slack is not passing the original message object along with the payload. To respond, you must construct a new message. I've experienced issues where my updated message is attributed to the App and not the bot. Not sure what I'm doing wrong still, passing
as_user: truedoesnt seem to work.To send an ephemeral message as part of a normal conversation, add
ephemeral: trueto the message body. See the updated docs for an example