add Pharo 11 (make Pharo 10) #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fniephaus
requested changes
Apr 5, 2022
|
no, no, tests are needed!
(I just forgot they were there... doing this once each N months does that... my brain is not the same as before ;) )
…On Apr 5 2022, at 2:00 pm, Fabio Niephaus ***@***.***> wrote:
@fniephaus requested changes on this pull request.
The builds are failing due to the bash-level tests not being up-to-date. If you think we don't need them, please feel free to drop them.
In pharo/run.sh (#551 (comment)):
> @@ -21,6 +21,9 @@ pharo::get_image_url() {
"Pharo64-stable")
echo "get.pharo.org/64/stable"
;;
+ "Pharo64-11")
+ echo "get.pharo.org/64/110"
The "Pharo32-11" image seems to be missing, you've added a VM for it below.
In pharo/run.sh (#551 (comment)):
> ;;
"Pharo64-stable")
- echo "get.pharo.org/64/vm90"
+ echo "get.pharo.org/64/vm10"
+ ;;
+ "Pharo64-11")
Could you please add "Pharo64-11" to the build matrix: https://github.com/hpi-swa/smalltalkCI/blob/master/.github/workflows/main.yml#L31
—
Reply to this email directly, view it on GitHub (#551 (review)), or unsubscribe (https://github.com/notifications/unsubscribe-auth/AAD5MXWRJHK4UFIMYDYKG5TVDQTOTANCNFSM5SSFJ6CA).
You are receiving this because you authored the thread.
|
|
now it should be ready |
|
We can add Pharo 11 to .github/workflows/main.yml , so at least we will notice if it broke with some future changes. |
|
yeah, problem is there is no p11 image yet ;)
…On Apr 5 2022, at 3:38 pm, Gabriel Omar Cotelli ***@***.***> wrote:
We can add Pharo 11 to .github/workflows/main.yml , so at least we will notice if it broke with some future changes.
—
Reply to this email directly, view it on GitHub (#551 (comment)), or unsubscribe (https://github.com/notifications/unsubscribe-auth/AAD5MXR6MDCB3JFB7ARUG3DVDQ65DANCNFSM5SSFJ6CA).
You are receiving this because you authored the thread.
|
|
If Pharo32-11 is only supported on arm, maybe we shouldn't support it until someone explicitly asked for it and can test it? Please let me know when there is a Pharo 11 image, so that I can restart the checks and merge this. |
|
Hi, now we have pharo11 images. |
|
The Pharo 11 build fails with:
https://github.com/hpi-swa/smalltalkCI/runs/6008160625?check_suite_focus=true#step:4:92 |
|
I know :)
working on it.
…On Apr 13 2022, at 3:45 pm, Fabio Niephaus ***@***.***> wrote:
The Pharo 11 build fails with:
> Instance of UnixEnvironment did not understand #getEnv:
https://github.com/hpi-swa/smalltalkCI/runs/6008160625?check_suite_focus=true#step:4:92
—
Reply to this email directly, view it on GitHub (#551 (comment)), or unsubscribe (https://github.com/notifications/unsubscribe-auth/AAD5MXXKILG25TIV5WDZNODVE3FXPANCNFSM5SSFJ6CA).
You are receiving this because you authored the thread.
|
|
voilà :) |
|
ping |
fniephaus
reviewed
Apr 13, 2022
| "name" : "SmalltalkCIPharo11", | ||
| "pools" : [ | ||
| ], | ||
| "super" : "SmalltalkCIPharo9", |
There was a problem hiding this comment.
I think this should eventually inherit from Pharo 10, not 9, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.