Start fixing tests.

spec/controllers/application_letters_controller_spec.rb

@@ -32,21 +32,24 @@
   describe "GET #index" do
     it "assigns all applications as @applications" do
       application = ApplicationLetter.create! valid_attributes
-      get :index, session: valid_session
+      sign_in application.user
+      get :index
       expect(assigns(:application_letters)).to eq([application])
     end
   end
 
   describe "GET #show" do
     it "assigns the requested application as @application" do
       application = ApplicationLetter.create! valid_attributes
-      get :show, id: application.to_param, session: valid_session
+      sign_in application.user
+      get :show, id: application.to_param
       expect(assigns(:application_letter)).to eq(application)
     end
   end
 
   describe "GET #new" do
     it "assigns a new application as @application" do
+      sign_in FactoryGirl.create(:user)
       get :new, session: valid_session
       expect(assigns(:application_letter)).to be_a_new(ApplicationLetter)
     end
@@ -55,6 +58,7 @@
   describe "GET #edit" do
     it "assigns the requested application as @application" do
       application = ApplicationLetter.create! valid_attributes
+      sign_in application.user
       get :edit, id: application.to_param, session: valid_session
       expect(assigns(:application_letter)).to eq(application)
     end
@@ -63,30 +67,36 @@
   describe "POST #create" do
     context "with valid params" do
       it "creates a new Application" do
+        sign_in FactoryGirl.create(:user)
         expect {
           post :create, application_letter: valid_attributes, session: valid_session
         }.to change(ApplicationLetter, :count).by(1)
       end
 
       it "assigns a newly created application as @application" do
+        sign_in FactoryGirl.create(:user)
         post :create, application_letter: valid_attributes, session: valid_session
         expect(assigns(:application_letter)).to be_a(ApplicationLetter)
         expect(assigns(:application_letter)).to be_persisted
       end
 
       it "redirects to the created application" do
+        sign_in FactoryGirl.create(:user)
         post :create, application_letter: valid_attributes, session: valid_session
         expect(response).to redirect_to(ApplicationLetter.last)
       end
     end
 
     context "with invalid params" do
       it "assigns a newly created but unsaved application as @application_letter" do
+        user = FactoryGirl.create(:user)
+        sign_in user
         post :create, application_letter: invalid_attributes, session: valid_session
-        expect(assigns(:application_letter)).to be_a_new(ApplicationLetter)
+        expect(assigns(:application_letter)).to be_a_new(ApplicationLetter).with(:user_id => user.id)
       end
 
       it "re-renders the 'new' template" do
+        sign_in FactoryGirl.create(:user)
         post :create, application_letter: invalid_attributes, session: valid_session
         expect(response).to render_template("new")
       end

spec/factories/users.rb

@@ -23,5 +23,6 @@
     sequence(:name) { |n| "First Last #{n}" }
     email { "#{name}@example.com".downcase.tr(" ","_") }
     password "test123"
+    role :pupil
   end
 end