Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2x faster MosesTokenizer #149

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

de9uch1
Copy link

@de9uch1 de9uch1 commented May 26, 2024

I have added two speed improvements:

  • Compile regex patterns.
  • Pre-define the character sets for islower() and isanyalpha().

Before:

Benchmark 1: python -m sacremoses -l en -j 1 tokenize < big.txt
  Time (mean ± σ):     14.799 s ±  0.875 s    [User: 16.009 s, System: 0.047 s]
  Range (min … max):   13.994 s … 16.786 s    10 runs

After:

Benchmark 1: python -m sacremoses -l en -j 1 tokenize < big.txt
  Time (mean ± σ):      7.669 s ±  0.653 s    [User: 8.313 s, System: 0.054 s]
  Range (min … max):    5.934 s …  8.252 s    10 runs

The results of unittest:

python -m unittest sacremoses/test/test_*
..........................s............
----------------------------------------------------------------------
Ran 39 tests in 5.028s

OK (skipped=1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant