3. Longest Substring Without Repeating Characters #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ryotaro25
reviewed
Mar 22, 2025
| if len(s) == 0 { | ||
| return 0 | ||
| } | ||
| charToLastIndex := make(map[byte]int) |
There was a problem hiding this comment.
確認済みかもですが、ASCIIの特性を活かした解法もあるようです🙇♂️
philip82148/leetcode-swejp#3
There was a problem hiding this comment.
共有ありがとうございます。書いてみました。
const AsciiCodepointNum = 128
func lengthOfLongestSubstring(s string) int {
var charLastIndex [AsciiCodepointNum]int
for i := range charLastIndex {
charLastIndex[i] = -1
}
result := 0
substringStartIndex := 0
for i := 0; i < len(s); i++ {
if charLastIndex[uint8(s[i])] >= substringStartIndex {
substringStartIndex = charLastIndex[uint8(s[i])] + 1
}
charLastIndex[uint8(s[i])] = i
result = max(result, i-substringStartIndex+1)
}
return result
}
Ryotaro25
reviewed
Mar 22, 2025
| } | ||
| ``` | ||
|
|
||
| ### CS |
oda
reviewed
Mar 22, 2025
| #### 2a | ||
| - step1の修正 | ||
| - https://github.com/olsen-blue/Arai60/pull/49/files#diff-eaf04e4839867b1c256a01b37e3fd908cd889582123148e5910d72e4e4fcb421R53 | ||
| - 自分のやりたいことをより少ない行数で実装していた |
There was a problem hiding this comment.
そうですね。上のコードを見て、形式的にも色々できそうですね。
たとえば、ループで次に行くときに right++ をしているので for に直りそうとか、実は、= right のところが同じとか。
olsen-blue
reviewed
Mar 29, 2025
Comment on lines
+167
to
+168
| - UnicodeとUTF-8 | ||
| - いつもわからなくなる |
olsen-blue
reviewed
Mar 29, 2025
| charToLastIndex := make(map[rune]int) | ||
| result := 0 | ||
| left := 0 | ||
| for right, c := range s { |
There was a problem hiding this comment.
私は、グリッドのインデックスにr, cを使いがちなので、一瞬 c の意味を捉えられませんでした。charと書いても良いのかもしれないですね。
同時に私も r, c ではなく row, col と書いた方が良いかもという気がしてきました...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://leetcode.com/problems/longest-substring-without-repeating-characters/description/