Implement custom variable register api (simple version) #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrsh7th
force-pushed
the
custom-variable-simple
branch
from
b202842
to
480cc78
Compare
hrsh7th
commented
Aug 11, 2020
autoload/vsnip/variable.vim
Outdated
| let l:selected_text = vsnip#selected_text() | ||
| if !empty(l:selected_text) | ||
| " TODO: fix indentation with a:context | ||
| return l:selected_text |
There was a problem hiding this comment.
Currently, s:Variable.resolve can't provide detailed context to fix the indentation so we should re-design s:Variable.resolve timing.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is simplified version of #94.
The omitted feature is the variable resolving at every synchronization.
For example, #95 can create
$BORDERcustom variable but this not.However, I think the feature is too rich so this PR is reasonable too.