Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kingdom Hearts Birth By Sleep [FM too] (Corrupted FB Effects) #3237

Closed
VIRGINKLM opened this issue Aug 19, 2013 · 5 comments
Closed

Kingdom Hearts Birth By Sleep [FM too] (Corrupted FB Effects) #3237

VIRGINKLM opened this issue Aug 19, 2013 · 5 comments

Comments

@VIRGINKLM
Copy link
Contributor

I believe #3108 messed up these already buggy parts of the game.

History:

v0.8.1-1332-gebb2aba - Known bugs exist.
ppssppwindows 2013-08-19 04-53-58-68
ppssppwindows 2013-08-19 05-05-33-73
ppssppwindows 2013-08-19 05-05-39-45
ppssppwindows 2013-08-19 05-05-45-13

v0.8.1-1340-g161556d - More bugs introduced over the others.
ppssppwindows 2013-08-18 05-14-31-10
ppssppwindows 2013-08-18 05-14-37-19
ppssppwindows 2013-08-18 05-14-21-22
ppssppwindows 2013-08-18 05-14-45-25

Those FB effects and render-to-texture effects are such a pain in the a**...

@dbz400
Copy link
Contributor

dbz400 commented Aug 19, 2013

If uncomment the AttachFramebufferInvalid() .i.e. bind the FB again here , does it help ?

            // If it already has one, let's hope that one is correct.
            // Try to not bind FB now as it seems to be attached some strange stuff on top of the original FB.
            //AttachFramebufferInvalid(entry, framebuffer);

@unknownbrackets
Copy link
Collaborator

Yeah, this is an effect of rendering garbage memory because that's commented out. Either Invalid or Valid would be better.

To be clear, of course, it doesn't attach anything on top of the existing framebuffer. It attaches something rather than rendering raw memory that has never seen anything rendered to it.

-[Unknown]

@VIRGINKLM
Copy link
Contributor Author

If you watch closely, on the bugged out scene with the color garbage, there should be a focus blur effect that doesn't get rendered but the garbage get rendered instead and the rest of the scene gets rendered without the blur, so apparently that garbage is that effect gone wrong.

@dbz400
Copy link
Contributor

dbz400 commented Aug 20, 2013

Looks good Now?

@VIRGINKLM
Copy link
Contributor Author

Yep, sorry for the delay but I didn't have access to my PC, seems OK again (back to the known bugs).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants