-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toaru Kagaku no Railgun no background since v0.9.1-1144-gf8eebdb #5087
Comments
can confirm that this happens regardless of buffer mode and also happens with the softgpu |
Tested a little further. It's indeed d7ae3f8 and using the now deleted hack of |
May be we can mark the title as Beizer issue . |
I guess it could even be using a different prim type than GE_PATCHPRIM_TRIANGLES? -[Unknown] |
No, that's not it, that would return before it even got to the call, I'm digging a little deeper currently. |
I did try to comment out below, didn't help
|
PPSSPP v0.9.6-466 same problem |
…stuff in addition to fixing hrydgard#5087
…stuff in addition to fixing hrydgard#5087
I'm going to need people to test b49fa80 with as many games as possible that use bezier splines to figure out whether any of the them uses view matrix transformed bezier splines. Here's a vdeo demonstrating the test with Toaru Kagaku no Railgun: http://www.youtube.com/watch?v=PjXefvWPitY |
That's great that they work with both. If anyone wants to test additional games please use Bigpet@2f7243b , you won't need to re-test games you already tested. This automatically preserves the through mode bit, so no need to toggle it in the settings. |
Don't truncate the through mode bit in the vertex type during normalization. Normalization is used to convert different vertex types to a singular normalized one but the through-mode bit should be preserved. This only affects (fixes) spline and bezier draw commands. The only thing that was broken was games that drew splines/beziers with through-mode and have matricies that differ significantly from the identity (didn't load identity before drawing). This should not break anything and fix hrydgard#5087 .
Cong @Bigpet |
Good
v0.9.1-1114-g36fd5df (I have compile myself to test)
Bad
v0.9.1-1144-gf8eebdb
compare v0.9.1-1114-g36fd5df...v0.9.1-1144-gf8eebdb
git bisect result
It is @hrydgard commit
d7ae3f8
v0.9.1-1114-g36fd5df log
https://gist.github.com/sum2012/b4fa38e617ba0053d6a4
PPSSPP v0.9.6-406-g62eb701 log (dump to next frame to log)
https://gist.github.com/sum2012/c9a594eafc2fe7922420
The text was updated successfully, but these errors were encountered: