Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return errors on Audio2 release when channel busy #12121

Merged
merged 2 commits into from
Jun 24, 2019

Conversation

unknownbrackets
Copy link
Collaborator

@unknownbrackets unknownbrackets commented Jun 23, 2019

Matches some tests for reserve and release on a PSP (hrydgard/pspautotests#201.)

Related changes:

  • Report the strange format 4 error for SRC reserve.
  • Reject invalid frequencies per tests (note: I'm pretty sure these frequencies are not actually handled now...)
  • Ignore MSB of sample count (maybe this was to avoid some exploit path?)

Should fix #6842 (it does for me, although I'm getting invalid memory access due to using demo data I think.) Also seems to fix #7445, woo.

-[Unknown]

@unknownbrackets unknownbrackets added this to the v1.9.0 milestone Jun 23, 2019
@hrydgard hrydgard merged commit bf4a507 into hrydgard:master Jun 24, 2019
@unknownbrackets unknownbrackets deleted the audio2-release branch June 24, 2019 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MotorStorm artic edge Playable but wo/ sound Quake 2 by CROW_BAR: distorted music issues
2 participants