UI: Round wave coords to prevent gaps #18210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrydgard
approved these changes
Sep 23, 2023
|
Think it can be solved without rounding - but that would require rewriting it have the rect function take x1 and x2 instead of x and width. This is fine. |
|
Well, just adding in the loop instead of multiplying is enough to fix the one observed case, but I was worried there'd be some annoying overlap or gap scenario still. Although this does round to dp. But I think it's the safest way to ensure no gaps or overlap. -[Unknown] |
This was referenced Oct 4, 2023
Merged
hrydgard
reviewed
Oct 4, 2023
| t *= speed; | ||
|
|
||
| float stepx = x; |
There was a problem hiding this comment.
Hm, I think this x input here shouldn't be used... accidentally uses the focus position.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18178. Should work fine until we hit 16000K resolutions. But by then hopefully no one will be able to notice the nanometer wide gaps.
-[Unknown]