Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulkan: Simplify pipeline and descriptor set layout, pool creation #18320

Merged
merged 6 commits into from
Oct 8, 2023

Conversation

hrydgard
Copy link
Owner

@hrydgard hrydgard commented Oct 8, 2023

Wrap pipeline/descriptor-layout in a new object VKRPipelineLayout, and simplify the creation of those, and also of matching descriptor set pools.

This is early preparatory work for moving Vulkan descriptor set management off to the render thread, to speed up the main thread. This PR on its own shouldn't have any visible effect.

@hrydgard hrydgard added the Code Cleanup Cleanup to make future work easier. Needs to be done sometimes. label Oct 8, 2023
@hrydgard hrydgard added this to the v1.17.0 milestone Oct 8, 2023
@hrydgard hrydgard changed the title Simplify pipeline and descriptor set layout, pool creation Vulkan: Simplify pipeline and descriptor set layout, pool creation Oct 8, 2023
@hrydgard hrydgard added the Vulkan label Oct 8, 2023
@hrydgard hrydgard merged commit 43cdb88 into master Oct 8, 2023
18 checks passed
@hrydgard hrydgard deleted the simplify-desc-set-layout branch October 8, 2023 12:12
@master1274
Copy link

Shield Tablet 32GB/LTE, Tegra K-1, Android 7.0, ARMv7, 320 dpi(1920х1200), OpenGL ES 3.2, Vulkan 1.0, Core 4x ARM Cortex-A15 - 2218 MHz.
v1.16.5-153-g43cdb88ac Completely non-working Vulkan.

@hrydgard
Copy link
Owner Author

hrydgard commented Oct 9, 2023

@master1274 thanks, I'll investigate soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Cleanup Cleanup to make future work easier. Needs to be done sometimes. Vulkan
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants