Reduced lower scope for local objects #18581
Conversation
Core/Util/DisArm64.cpp
Outdated
| @@ -508,6 +507,7 @@ static void DataProcessingRegister(uint32_t w, uint64_t addr, Instruction *instr | |||
| if (opn < 4 && Ra == 31) { | |||
| snprintf(instr->text, sizeof(instr->text), "%cmull x%d, w%d, w%d", sign, Rd, Rn, Rm); | |||
| } else { | |||
| const char* opnames[8] = { 0, 0, "maddl", "msubl", "smulh", 0, 0, 0 }; | |||
There was a problem hiding this comment.
while at it, can make this static const char * const
There was a problem hiding this comment.
check this fix in here: 2a31f8c
GPU/Common/ShaderId.cpp
Outdated
| int ls0 = id.Bits(VS_BIT_LS0, 2); | ||
| int ls1 = id.Bits(VS_BIT_LS1, 2); | ||
|
|
||
| if (uvgMode) desc << uvgModes[uvgMode]; | ||
| if (uvgMode) { | ||
| const char* uvgModes[4] = { "UV ", "UVMtx ", "UVEnv ", "UVUnk " }; |
There was a problem hiding this comment.
fixed it here commit: ca94de8
GPU/Common/TransformCommon.cpp
Outdated
| // Better specular | ||
| // Vec3f toViewer = (viewer - pos).NormalizedOr001(cpu_info.bSSE4_1); | ||
|
|
||
| if (doSpecular) { | ||
| // Real PSP specular | ||
| Vec3f toViewer(0, 0, 1); |
There was a problem hiding this comment.
fixed it here ca94de8
Windows/GEDebugger/TabState.cpp
Outdated
| const int mipLevel = value & 0xFFFF; | ||
| const int biasFixed = (s8)(value >> 16); | ||
| const float bias = (float)biasFixed / 16.0f; | ||
|
|
||
| if (mipLevel == 0 || mipLevel == 1 || mipLevel == 2) { | ||
| const char* mipLevelModes[] = { |
There was a problem hiding this comment.
Also it's not really needed to move those into the closest scope, since they'll be preinitialized anyway.
There was a problem hiding this comment.
fix it here 95f535d
…eration (lower level scope)
…etter codegeneration (lower level scope)
…on (lower level scope)
GermanAizek
force-pushed
the
lower-scope
branch
from
4c8c38d
to
95f535d
Compare
| if (uri.NavigateUp()) { | ||
| std::string newDirName = uri.GetLastPart(); |
There was a problem hiding this comment.
This change broke directory creation, because uri.NavigateUp actually changes the URI object, so the order changes the outcome. Fix coming up
There was a problem hiding this comment.
I'm not sure I've seen a compiler where many of these would be any better.
My personal preference would be to instead optimize for code readability rather than a trash toy compiler. Maybe even as an added benefit, find a way to make PPSSPP fail to even compile on a compiler so bad that the scope of static const char *foo[] changes generated code performance.
-[Unknown]
| @@ -364,7 +364,6 @@ namespace SaveState | |||
| } | |||
|
|
|||
| // Memory is a bit tricky when jit is enabled, since there's emuhacks in it. | |||
| auto savedReplacements = SaveAndClearReplacements(); | |||
There was a problem hiding this comment.
This change looks very bad and probably broke save states?
-[Unknown]
There was a problem hiding this comment.
Yeah, sigh. Should have reviewed this one more closely.
| @@ -619,7 +619,6 @@ void ClearCallback() { | |||
|
|
|||
| static void FinishRecording() { | |||
| // We're done - this was just to write the result out. | |||
| Path filename = WriteRecording(); | |||
There was a problem hiding this comment.
This can't be good. Certainly broke frame dumps.
-[Unknown]
@hrydgard,
Reducing scope object leads to early destruction, as well as faster local variables for conditional branches. There is no reason to create an object earlier before conditional branching, which in some ways does not access to object.