Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Go!Explore🗺️🧭 issue with GetDirListing(/); closes #15932 #18665

Merged
merged 1 commit into from
Jan 6, 2024
Merged

Fix Go!Explore🗺️🧭 issue with GetDirListing(/); closes #15932 #18665

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Core/FileSystems/ISOFileSystem.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -647,6 +647,9 @@ std::vector<PSPFileInfo> ISOFileSystem::GetDirListing(const std::string &path, b
*exists = false;
return myVector;
}
if (entry == &entireISO) {
entry = GetFromPath("/");
}
Comment on lines +650 to +652
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, would it make more sense to do the check inside of GetFromPath instead?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually it wouldn't, because we only want it to trigger during listings, not when trying to open the root as a file.

So, I'm going to merge this as-is.


const std::string dot(".");
const std::string dotdot("..");
Expand Down