Correct error codes and dup checks in intr registration #6389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This checks for duplicate registrations and other thigns that could've been causing wrong behavior.
Could've caused interrupts, primarily vblanks, not to run because we implicitly disabled them on register.
|
@unknownbrackets Well done |
hrydgard
added a commit
that referenced
this pull request
Jun 22, 2014
Correct error codes and dup checks in inter registration
unknownbrackets
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a game in a log registered the same subintr twice. I checked and that is not allowed.
This corrects a bunch of error codes and some of the handling there, which could fix games with bugs or that check error codes.
-[Unknown]