Skip to content

v0.1.7

Choose a tag to compare

@hsnice16 hsnice16 released this 15 Oct 19:40
· 4 commits to main since this release
afd40ea

Changed

  • Check details print counts as "14,688 characters" instead of "14688 chars", and say "1 GitHub Actions workflow" / "2 … workflows" instead of "workflow(s)". Check descriptions are reworded in plain language. Scores are unchanged. Vendored from the upstream scorer.
  • The comment's "Signals that changed" section is now "Checks that changed", the name the website uses.

Fixed

  • The Cursor-rules check's detail for a legacy .cursorrules file no longer contains backticks, which would print literally now that details render as code spans. Scores are unchanged. Vendored from the upstream scorer.
  • The file a check names as its match (the first test file, .cursor/rules/*.mdc or *.csproj-style manifest) is now picked by name instead of directory-listing order, so the same commit reports the same file on every machine. Scores are unchanged. Vendored from the upstream scorer.

Security

  • The scorer no longer follows a symlink out of the scored repo, reads only regular files, and reads at most 1 MiB of any file. A tree with README.md linked to /dev/zero could exhaust memory, and one linked to a file elsewhere on the machine leaked that file's length into the score. An escaping link still counts as one file for the size check; a README over 1 MiB is measured on its first 1 MiB. Scores of ordinary repos are unchanged. Vendored from the upstream scorer.
  • The action now edits only a comment it posted itself. It used to update any PR comment carrying its hidden marker, so anyone could paste the marker into a comment and have the score diff overwrite it. With a PAT, "itself" is the PAT's account. With an installation token (the default GITHUB_TOKEN, or a GitHub App's, which comments as <app-slug>[bot]) it is any bot account, so App tokens keep updating one comment; a user account's comment is never edited.
  • Signal details in the comment render as code spans. A detail can quote a file name from the PR, which could otherwise inject Markdown, links, images or @-mentions into the bot's comment.
  • base-ref values that git could read as an option (a leading -, or characters no ref name allows) are refused, and refs are passed to git after --end-of-options. Branch names, SHAs and revisions such as HEAD~1, HEAD^2 and main@{1} still work.