Skip to content

add createStream method with replicationFactor parameter #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2021
Merged

add createStream method with replicationFactor parameter #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion client/src/main/java/io/hstream/HStreamClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,20 @@ static HStreamClientBuilder builder() {
/** @return the {@link QueryerBuilder}. */
QueryerBuilder newQueryer();

/** @param stream the name of stream. */
/**
* create a new stream with 3 replicas.
*
* @param stream the name of stream.
*/
void createStream(String stream);

/**
* create a new stream.
*
* @param stream the name of stream.
*/
void createStream(String stream, short replicationFactor);

/**
* Delete specified stream with streamName.
*
Expand Down
8 changes: 7 additions & 1 deletion client/src/main/java/io/hstream/impl/HStreamClientImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ public class HStreamClientImpl implements HStreamClient {
private final HStreamApiGrpc.HStreamApiStub stub;
private final HStreamApiGrpc.HStreamApiBlockingStub blockingStub;

private static final short DEFAULT_STREAM_REPLICATOR = 3;

public HStreamClientImpl(String serviceUrl) {
ManagedChannel channel = ManagedChannelBuilder.forTarget(serviceUrl).usePlaintext().build();
this.managedChannel = channel;
Expand All @@ -47,8 +49,12 @@ public QueryerBuilder newQueryer() {

@Override
public void createStream(String streamName) {
Stream stream = new Stream(streamName, 3);
createStream(streamName, DEFAULT_STREAM_REPLICATOR);
}

@Override
public void createStream(String streamName, short replicationFactor) {
Stream stream = new Stream(streamName, replicationFactor);
blockingStub.createStream(GrpcUtils.streamToGrpc(stream));
}

Expand Down