Skip to content

bug fixed: use proper type to handle exception correctly in writeInternal and flush #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 30, 2021
Merged

bug fixed: use proper type to handle exception correctly in writeInternal and flush #45

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions client/src/main/kotlin/io/hstream/impl/ProducerKtImpl.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,13 @@ class ProducerKtImpl(
return if (!enableBatch) {
val future = CompletableFuture<RecordId>()
writeHStreamRecords(listOf(hStreamRecord))
.handle<Any?> { recordIds: List<RecordId>, exception: Throwable? ->
// WARNING: Do not explicitly mark the type of 'recordIds'!
// The first argument of handle is of type 'List<RecordId>!'.
// If it is explicitly marked as 'List<RecordId>', a producer
// will throw an exception but can not be handled because of
// inconsistent type when it exhausts its retry times. This
// causes the whole program to be stuck forever.
.handle<Any?> { recordIds, exception: Throwable? ->
if (exception == null) {
future.complete(recordIds[0])
} else {
Expand All @@ -88,7 +94,13 @@ class ProducerKtImpl(
val recordBufferCount = recordBuffer!!.size
logger.info("start flush recordBuffer, current buffer size is: {}", recordBufferCount)
writeHStreamRecords(recordBuffer)
.handle<Any?> { recordIds: List<RecordId>, exception: Throwable? ->
// WARNING: Do not explicitly mark the type of 'recordIds'!
// The first argument of handle is of type 'List<RecordId>!'.
// If it is explicitly marked as 'List<RecordId>', a producer
// will throw an exception but can not be handled because of
// inconsistent type when it exhausts its retry times. This
// causes the whole program to be stuck forever.
.handle<Any?> { recordIds, exception: Throwable? ->
if (exception == null) {
for (i in recordIds.indices) {
futures!![i].complete(recordIds[i])
Expand Down