Skip to content

fix init clusterServerUrls #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 4, 2022
Merged

fix init clusterServerUrls #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion client/src/main/kotlin/io/hstream/impl/HStreamClientKtImpl.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,13 +42,14 @@ class HStreamClientKtImpl(bootstrapServerUrls: List<String>) : HStreamClient {
val describeClusterResponse = unaryCallWithCurrentUrls(bootstrapServerUrls, channelProvider) { stub -> stub.describeCluster(Empty.newBuilder().build()) }
val serverNodes = describeClusterResponse.serverNodesList
val serverUrls: ArrayList<String> = ArrayList(serverNodes.size)
clusterServerUrls.compareAndSet(null, serverUrls)
clusterServerUrls.set(serverUrls)
for (serverNode in serverNodes) {
val host = serverNode.host
val port = serverNode.port
logger.info("serverUrl: {}", "$host:$port")
serverUrls.add("$host:$port")
}
logger.info("clusterServerUrls: {}", clusterServerUrls.get())
}

override fun close() {
Expand Down
6 changes: 5 additions & 1 deletion client/src/main/kotlin/io/hstream/impl/Utils.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import java.util.concurrent.atomic.AtomicReference
val logger: Logger = LoggerFactory.getLogger("kt-coroutine-utils")

suspend fun <Resp> unaryCallWithCurrentUrlsCoroutine(serverUrls: List<String>, channelProvider: ChannelProvider, call: suspend (stub: HStreamApiCoroutineStub) -> Resp): Resp {
check(serverUrls.isNotEmpty())
logger.info("unaryCallWithCurrentUrl urls are {}", serverUrls)
for (i in serverUrls.indices) {
val stub = HStreamApiCoroutineStub(channelProvider.get(serverUrls[i]))
Expand Down Expand Up @@ -58,8 +59,11 @@ suspend fun <Resp> unaryCallCoroutine(urlsRef: AtomicReference<List<String>>, ch
} catch (e: Exception) {
logger.warn("unary call error for url: {}", urls[0], e)
if (urls.size > 1) {
logger.info("before refreshClusterInfo, urls are {}", urls)
val newServerUrls = refreshClusterInfo(urls.subList(1, urls.size), channelProvider)
urlsRef.compareAndSet(urls, newServerUrls)
// urlsRef.compareAndSet(urls, newServerUrls)
urlsRef.set(newServerUrls)
logger.info("after refreshClusterInfo, urls are {}", urlsRef.get())
return unaryCallWithCurrentUrlsCoroutine(urlsRef.get(), channelProvider, call)
} else {
throw e
Expand Down