Skip to content

Add a conditional compilation directive to be compatible with C++26 #1367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 1, 2025
Merged

Add a conditional compilation directive to be compatible with C++26 #1367

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
96c9211
Add a conditional compilation directive to be compatible with C++26
vspefs Feb 12, 2025
04407a1
fix typo
vspefs Feb 12, 2025
88c8bbc
Tweak comment before merging
hsutter Mar 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions source/common.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -580,12 +580,9 @@ auto print_with_thousands(T val)
}


// In keep trying to write string+string_view, and it ought to Just Work without
// the current workarounds. Not having that is a minor impediment to using safe
// and efficient string_views, which we should be encouraging. So for my own use
// and to remove that minor impediment to writing safe and efficient code, I'm
// just going to add this until we get P2591 in C++26(?) -- See: wg21.link/p2591
//
// Provide string+string_view if P2591 is not available.
//
#if __cpp_lib_string_view < 202403L
template<class charT, class traits, class Allocator>
[[nodiscard]] constexpr auto operator+(
std::basic_string<charT, traits, Allocator> lhs,
Expand All @@ -605,6 +602,7 @@ template<class charT, class traits, class Allocator>
{
return rhs.insert(0, lhs);
}
#endif


//-----------------------------------------------------------------------
Expand Down