Fix cpp2::to_string to call cpp2::to_string instead of std::to_string #39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specialisation of
cpp2::to_string
function forstd::optional
is usingstd::to_string
on optional value.That makes the below code fail to compile:
cppfront will generate
The result is that there is a call to
std::to_string(std::string)
and there is no such specialization in the standard library.Closes #38